Fix coverage detection on SQLAlchemy calls #26
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suite de #24
Cette PR corrige le comportement de la détection de coverage pour les lignes suivant un appel à la BDD.
En effet, le support de async dans SQLAlchemy fait appel à greenlet, une implémentation de coroutines pour Python. Coverage.py a besoin d'un flag explicite pour être compatible avec greenlet (par défaut
concurrency = thread
seulement), sinon les lignes suivant un appel à greenlet peuvent ne pas être détectées (voir nedbat/coveragepy#1082), comme c'est le cas ici.Le coverage monte 91% -> 97%, car des lignes étaient ignorées à cause de ce pb. :-)